It's a part of code, that i replaced in samsung-tools:
if os.path.exists(spam):
return True
else:
return False
That's code is incorrect. Why? Just its extra (not needed) operation. We can do that and it will be correct:
return os.path.exists(spam)
Its not just simple, it's correct. And i'm ...
Search found 8 matches
- 16 Jul 2013, 14:29
- Forum: Linux On My Samsung
- Topic: SamsungTools — FORKED
- Replies: 10
- Views: 52169
- 15 Jul 2013, 12:42
- Forum: Linux On My Samsung
- Topic: SamsungTools — FORKED
- Replies: 10
- Views: 52169
Re: SamsungTools — FORKED
For the sake of clarity.
If user look at code, he should know python or basis of programming. Python as original is easy to understand. Making program slower for better reading is a bad tone. Need a average of it. All web-developers doing optimization of their code: they using 1/0 instread of ...
- 15 Jul 2013, 12:24
- Forum: Linux On My Samsung
- Topic: SamsungTools — FORKED
- Replies: 10
- Views: 52169
Re: SamsungTools — FORKED
voRia, I just wanted to draw your attention to this post. I tried many times to contact some developers of some python projects. They just ignores any additions.
After all. Can you accept my addition request to your jabberID? We can talk in it about code parts that you don't like and take a solution
After all. Can you accept my addition request to your jabberID? We can talk in it about code parts that you don't like and take a solution
- 15 Jul 2013, 12:16
- Forum: Linux On My Samsung
- Topic: SamsungTools — FORKED
- Replies: 10
- Views: 52169
Re: SamsungTools — FORKED
For example, you changed this:
with open(SL_PATH_BACKLIGHT, 'r') as file:
status = int(file.read(1))
if status == 0:
return True
else:
return False
with:
return not bool(int(rFile(SL_PATH_BACKLIGHT)[0]))
I don't like it.
Hello voRia! I just cleaned code. In your code, CPU doing excess ...
- 14 Jul 2013, 09:21
- Forum: Linux On My Samsung
- Topic: backlight off when brightness under a certain level
- Replies: 3
- Views: 14944
Re: backlight off when brightness under a certain level
try this (will work only when you run from battery):
add to /etc/rc.local before "exit 0":
add to /etc/rc.local before "exit 0":
Code: Select all
if !(on_ac_power); then
echo 3 > /sys/class/backlight/samsung/brightness
fi
- 12 Jul 2013, 17:22
- Forum: Linux On My Samsung
- Topic: Battery life extender 80%
- Replies: 9
- Views: 33154
Re: Battery life extender 80%
So, thanks for last post, i added it to my fork of Samsung Tools (still hope that voRia accept it
)
see here: http://www.voria.org/forum/viewtopic.ph ... 6193#p6193

see here: http://www.voria.org/forum/viewtopic.ph ... 6193#p6193
- 12 Jul 2013, 17:18
- Forum: Linux On My Samsung
- Topic: SamsungTools — FORKED
- Replies: 10
- Views: 52169
Re: SamsungTools — FORKED
As i said, i created .deb package.
Get it here: http://simpleapps.ru/samsung-tools_2.2_all.deb (Voria forum doesn't accept .deb)
Get it here: http://simpleapps.ru/samsung-tools_2.2_all.deb (Voria forum doesn't accept .deb)
- 12 Jul 2013, 16:38
- Forum: Linux On My Samsung
- Topic: SamsungTools — FORKED
- Replies: 10
- Views: 52169
SamsungTools — FORKED
Hello all, hello developers.
I created a simple fork for SamsungTools program.
First i cleaned code. It was not good and still its.
Next i added support for "battery life time extender" as developers and users wanted.
I hope you enjoy it, and hope, that developers accept me in their "team ...
I created a simple fork for SamsungTools program.
First i cleaned code. It was not good and still its.
Next i added support for "battery life time extender" as developers and users wanted.
I hope you enjoy it, and hope, that developers accept me in their "team ...